Add mingw declarations #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
reviewed
Jan 13, 2023
|
Yes. The easiest method would involve installing an msys2 environment, installing the required packages, and building. I believe msys2 only works on Windows. How would you like that added to the test matrix? I assume you would want it added somehow to the "test_on_many_oses" action? |
|
@nathaniel-daniel you are right, this is not entirely straightforward. I created another issue to track this in #182 ... contribution would be much welcomed! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a mingw declarations file to support that platform. It was copied from the cygwin definitions. I appear to be able to compile, load, and use this library from msys2 with this change.
__MINGW32__is defined for 64 bit targets as well as 32 bit. I only tested this on mingw64 through msys2, but I think this should work for the original mingw as well, though I'm not sure if people still use that.