Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling mods removes them entirely #25

Closed
Jian-Ng opened this issue Sep 1, 2023 · 2 comments
Closed

Disabling mods removes them entirely #25

Jian-Ng opened this issue Sep 1, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Jian-Ng
Copy link

Jian-Ng commented Sep 1, 2023

I was using the old version for a while before updating, I noticed that disabling mods no longer moves the mod folder to the "disabled-mods" folder, but rather the contents of the mod folder instead. I downloaded the mod from the releases page.

I have a few screenshots and a video attached. My software doesn't record the right-click somehow, but look to the right and you can see that the mod is disabled.

Myth.mod.manager.mp4

Screenshot 2023-09-01 223759
Screenshot 2023-09-01 223831

@Wolfmyths
Copy link
Owner

Thanks for giving me a informative bug report.

I'm so sorry this has happened here's an easy way to revert this if you don't have a backup of your mods:

  • Make a new folder in the disabled mods folder and rename it to the mod you want properly disabled
    • Go to mods.ini and find the mod that was disabled incorrectly to get the exact name if you can't remember the mod name
  • Move the correct contents of the mod into the newly created folder

If this has happened to more than one mod, reinstalling them works but remember to delete the incorrect files in the disabled mods directory

I will work on this as soon as I can.

@Wolfmyths
Copy link
Owner

This issue will be fixed and a patch will be released later today.

The issue was that the destination path for moving a mod to the disabled mods directory was not including the mod folder itself.

Before:

self.move(disabledModsPath, modDestPath)

After:

self.move(os.path.join(disabledModsPath, mod), modDestPath)

Thanks for reporting this bug it really means a lot.

@Wolfmyths Wolfmyths added the bug Something isn't working label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants