feature: Improve application discovery and configuration options #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ST_WOLFRAM_LOCATION * Add wolfram_app_discovery::config module to organize this functionality. * Using RUST_WOLFRAM_LOCATION will cause a deprecation warning message to be printed to stderr.
This is now consistent with the formatting of the other Wolfram crates: wolfram-expr wolfram-library-link wstp
…ror when `wolframscript` is not on PATH
This controls whether or not wolframa-app-discovery will print: cargo:rerun-if-env-changed=<VAR> statements. This is useful when wolfram-app-discovery is used in a cargo build.rs script (as in e.g. wstp).
…lications * Add new wolfram_app_discovery::find module to contain this logic * Replace the WolframApp.installation_directory field with app_directory * Add WolframApp.embedded_player field, which is used if the current app is a Wolfram Engine, which contains an embedded Wolfram Player.app on macOS. * `embedded_player` is Some, forward all WolframApp methods to the embedded instance.
|
Followup: This PR was missing one file that I forgot to commit, fixed in #6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fleshes out and polishes the code for discovering Wolfram applications, makes
wolfram-app-discoverywork better as a cargo build script dependency, and documents the configuration variable (WOLFRAM_APP_DIRECTORY) that can be used to override the default search locations.