Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search function truncation and "total highlighted" #56

Closed
ISeeTanamon opened this issue Aug 5, 2016 · 4 comments
Closed

Search function truncation and "total highlighted" #56

ISeeTanamon opened this issue Aug 5, 2016 · 4 comments

Comments

@ISeeTanamon
Copy link

Hi! Awesome work, wanted to leave a few bugs:

  1. Typing in "Pidgey" brings up Pidgey and Pidgeotto. Seems search is only taking the value up to "e" for some reason.
  2. When we highlight within the inapp cells, it'd be cool like in Excel / Word / Folder structures where we see at the bottom of a window, the status bar indicating how many are currently highlighted. This might be a dupe of another defect/enhancement where we're asking how many total Evolve's we've selected, etc.
@ISeeTanamon
Copy link
Author

Oh. I imagine its not truncating, but maybe theres a field thats indicating a previous evolution. I type in Ekans and Arbok shows up, probably some hidden field showing that Ekans is needed for the Arbok? /2cents.

@Wolfsblvt
Copy link
Owner

First one is cause you can also search for pokémon family. And Pidgey and Pigeottos family is Pidgey (:

Second is a good idea. We should add highlight count maybe when we rework selecting like in #24 suggested.

@phronx
Copy link

phronx commented Aug 5, 2016

Would it be possible to add the option to enable and disable search for pokémon family?

@Wolfsblvt
Copy link
Owner

Okay, show how much are selected will be added with #24 I would say.
For the second thing I have opened a new issue #62.

Will close this now here then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants