Feature/french translations #63
Conversation
|
Hiho, awesome work, there's another guy helping with the translations on discord (maybe you could join too Discord), I will try to update the fr.json file later with his changes, but from what I saw, debuffs / reactions / resonances, monsters and the general file are rdy btw could you remove the numbers that appears in the json file ? |
|
Ok, I've just pushed the latest changes to the french branch, please don't forget to fix these: |
|
Hi 😊
Thx 😊. Yes i’m coming in Discord. I’m just overbusy with my job at this moment so i work on the french translation between two task and …. My wife 😃
It’s normal that all file is translated in french. I use the google translate api ^_^ I read line by line, to check if it’s fine. But there is many correction to do:/ For the moment, only characters are validated.
Dont accept my PR, i just correct 2 mistakes in json format. I will do another to night.
btw could you remove the numbers that appears in the json file ? ==> What number ?
De : Efrain Bastidas ***@***.***>
Envoyé : jeudi 27 mai 2021 15:50
À : Wolfteam/GenshinDb ***@***.***>
Cc : therealcorwin ***@***.***>; Author ***@***.***>
Objet : Re: [Wolfteam/GenshinDb] Feature/french translations (#63)
Hiho, awesome work, there's another guy helping with the translations on discord (maybe you could join too Discord<https://discord.gg/A8SgudQMwP>), I will try to update the fr.json file later with his changes, but from what I saw, debuffs / reactions / resonances, monsters and the general file are rdy
btw could you remove the numbers that appears in the json file ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#63 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABJXZA2NSN7RI5OPS7YTDM3TPZEXTANCNFSM45UJ6OEQ>.
|
|
Damn, i missed your email :/
Holy S….t, my vscode addon mess up the file O_O. I have no the time to check this now. I’m whatching this to night
De : Efrain Bastidas ***@***.***>
Envoyé : jeudi 27 mai 2021 16:20
À : Wolfteam/GenshinDb ***@***.***>
Cc : therealcorwin ***@***.***>; Assign ***@***.***>
Objet : Re: [Wolfteam/GenshinDb] Feature/french translations (#63)
Ok, I've just pushed the latest changes to the french branch, please don't forget to fix these:
[Fix these]<https://user-images.githubusercontent.com/1976115/119842726-8e017c80-becc-11eb-8b48-8335b3985933.PNG>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#63 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABJXZA3KGG37CYDCQTQJSFTTPZIJJANCNFSM45UJ6OEQ>.
|
There was a problem hiding this comment.
Hi 😊 Thx 😊. Yes i’m coming in Discord. I’m just overbusy with my job at this moment so i work on the french translation between two task and …. My wife 😃 It’s normal that all file is translated in french. I use the google translate api ^_^ I read line by line, to check if it’s fine. But there is many correction to do:/ For the moment, only characters are validated. Dont accept my PR, i just correct 2 mistakes in json format. I will do another to night. btw could you remove the numbers that appears in the json file ? ==> What number ? De : Efrain Bastidas @.> Envoyé : jeudi 27 mai 2021 15:50 À : Wolfteam/GenshinDb @.> Cc : therealcorwin @.>; Author @.> Objet : Re: [Wolfteam/GenshinDb] Feature/french translations (#63) Hiho, awesome work, there's another guy helping with the translations on discord (maybe you could join too Discordhttps://discord.gg/A8SgudQMwP), I will try to update the fr.json file later with his changes, but from what I saw, debuffs / reactions / resonances, monsters and the general file are rdy btw could you remove the numbers that appears in the json file ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#63 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJXZA2NSN7RI5OPS7YTDM3TPZEXTANCNFSM45UJ6OEQ.
mm I don't think using google translate is a good idea though, it may confuse the users since the translations are not exactly like the game ones
| "skills": [ | ||
| { | ||
| "characters": { | ||
| "0": { |
There was a problem hiding this comment.
These numbers should be removed and the arrays must be kept
|
Hi,
I find the culprint ! It’s a bug from the json auto translation addon from Vscode ☹ I’m worked with the creator to fix this. In parallel, i fix the file.
Don’t worry about Google Translate API, for skill description it’s works pretty good. But need some fix. For characters/skill/weapon …. Name I check directly in the game or official Wiki to put the same name in game and for the app. No risk of confusion. I Hope :D
De : Efrain Bastidas ***@***.***>
Envoyé : vendredi 28 mai 2021 03:11
À : Wolfteam/GenshinDb ***@***.***>
Cc : therealcorwin ***@***.***>; Assign ***@***.***>
Objet : Re: [Wolfteam/GenshinDb] Feature/french translations (#63)
@Wolfteam commented on this pull request.
Hi 😊 Thx 😊. Yes i’m coming in Discord. I’m just overbusy with my job at this moment so i work on the french translation between two task and …. My wife 😃 It’s normal that all file is translated in french. I use the google translate api ^_^ I read line by line, to check if it’s fine. But there is many correction to do:/ For the moment, only characters are validated. Dont accept my PR, i just correct 2 mistakes in json format. I will do another to night. btw could you remove the numbers that appears in the json file ? ==> What number ? De : Efrain Bastidas @.> Envoyé : jeudi 27 mai 2021 15:50 À : Wolfteam/GenshinDb @.> Cc : therealcorwin @.>; Author @.> Objet : Re: [Wolfteam/GenshinDb] Feature/french translations (#63<#63>) Hiho, awesome work, there's another guy helping with the translations on discord (maybe you could join too Discordhttps://discord.gg/A8SgudQMwP), I will try to update the fr.json file later with his changes, but from what I saw, debuffs / reactions / resonances, monsters and the general file are rdy btw could you remove the numbers that appears in the json file ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#63 (comment)<#63 (comment)>>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJXZA2NSN7RI5OPS7YTDM3TPZEXTANCNFSM45UJ6OEQ.
mm I don't think using google translate is a good idea though, it may confuse the users since the translations are not exactly like the game ones
________________________________
In assets/i18n/fr.json<#63 (comment)>:
@@ -1,6300 +1,6300 @@
{
- "characters": [
- {
- "key": "Albedo",
- "name": "Albedo",
- "description": "Génie connu sous le surnom de Kreideprinz, Albedo est l'alchimiste en chef et le capitaine des enquêteurs de l'Ordre de Favonius.",
- "skills": [
- {
+ "characters": {
+ "0": {
These numbers should be removed and the arrays must be kept
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#63 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABJXZA5HTUMMDD7AYQPUGVLTP3UUBANCNFSM45UJ6OEQ>.
|
|
I close this PR due to the vscode addon bug. it's too difficult to correct the file. I restart from scratch this file :) |
First batch for French translation :
All Characters are translated in French.
TODO :