New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/french translations #82
Feature/french translations #82
Conversation
Characters are OK. Need a second pass to the rest. Hope this time, the file format is good :D Sorry for the delay, i'm overloaded :/
Okay, will release a beta version with the french translations applied so you can test it. Edit: There are some typos in the file :'C, fix those so I can merge this one |
Fix done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix done :)
emm.... nothing has been fixed
Oh OK. A little miss understanding. We are not talking about same things. I check this :) |
Hi @Wolfteam, Do you need more information before merge the update file ? Sorry, haven't i no time yet to make a second pass. I'm more available next week to translate 2.0 news and more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Wolfteam,
Do you need more information before merge the update file ? Sorry, haven't i no time yet to make a second pass. I'm more available next week to translate 2.0 news and more
Emm no, just fix the comments that I left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change done.
Left a few comments @therealcorwin |
Hi @Wolfteam, I just check the file, and i don't see what i forgot :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Wolfteam,
I just check the file, and i don't see what i forgot :/
Strange I don't see your review comment :/ I fix this in few minutes |
Fix : Diona description Fix : Xiao description
I just push some modifications |
@therealcorwin I did some updates on the general and main files (the new characters, weapons, etc). To join the beta program, go to the play store > genshindb > join beta program > wait 5 min. > go back and you should see an update |
Hi @Wolfteam, I use the beta version (1.1.5+108 Beta). First, when i update the app to the beta version, i can't choose French in setting's menu. I needed to delete cache/data. At first launch all the app and game data are in french. But if a want to swtich to english i can't roll back in french because i haven't this choice. Is't normal ? About translation, No big problem. Just fix some presentation, formulation, too long text. For exemple, some weapon's name are too long, can i use "\n" to write this on two line instead of one, or not ? |
Hiho, gonna push a fix for the problem now, should be up in 2hrs~. Yep you can use a line break to format the text. |
Version 109 beta tested. French option is available ;) Is there an easy solution in vscode or other to generate an APK with my translation to look at directly "in live" the modification on my computer/tablet ? I'll do some correction this weekend and V2 data if i have enough time :) |
Yes, just follow the instructions that are located in the [README (https://github.com/Wolfteam/GenshinDb/blob/main/README.md) file. After that, you should be able to run the app with one of the following commands: Desktop: Android: |
Hi :)
Sorry for the delay. I very busy.
Complete rework for French Translation due to a vscode addon bug.
==> Characters are OK.
==> Need a second pass to the rest
Hope this time, the file format is correct ;)
Fixes #13