Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/french translations #82

Merged
merged 45 commits into from Jul 30, 2021
Merged

Feature/french translations #82

merged 45 commits into from Jul 30, 2021

Conversation

therealcorwin
Copy link

@therealcorwin therealcorwin commented Jul 1, 2021

Hi :)

Sorry for the delay. I very busy.

Complete rework for French Translation due to a vscode addon bug.
==> Characters are OK.
==> Need a second pass to the rest

Hope this time, the file format is correct ;)

Fixes #13

Characters are OK.
Need a second pass to the rest.

Hope this time, the file format is good :D

Sorry for the delay, i'm overloaded :/
@Wolfteam
Copy link
Owner

Wolfteam commented Jul 7, 2021

Okay, will release a beta version with the french translations applied so you can test it.
Should be up in 2hrs ~

Edit: There are some typos in the file :'C, fix those so I can merge this one

@therealcorwin
Copy link
Author

Fix done :)

Copy link
Owner

@Wolfteam Wolfteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix done :)

emm.... nothing has been fixed

assets/i18n/fr.json Outdated Show resolved Hide resolved
assets/i18n/fr.json Outdated Show resolved Hide resolved
assets/i18n/fr.json Outdated Show resolved Hide resolved
assets/i18n/fr.json Outdated Show resolved Hide resolved
@therealcorwin
Copy link
Author

Oh OK. A little miss understanding. We are not talking about same things.

I check this :)

@Wolfteam Wolfteam added the t/translations translations label Jul 10, 2021
@therealcorwin
Copy link
Author

therealcorwin commented Jul 26, 2021

Hi @Wolfteam,

Do you need more information before merge the update file ? Sorry, haven't i no time yet to make a second pass. I'm more available next week to translate 2.0 news and more

Copy link
Owner

@Wolfteam Wolfteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wolfteam,

Do you need more information before merge the update file ? Sorry, haven't i no time yet to make a second pass. I'm more available next week to translate 2.0 news and more

Emm no, just fix the comments that I left

assets/i18n/fr.json Show resolved Hide resolved
assets/i18n/fr.json Outdated Show resolved Hide resolved
assets/i18n/fr.json Show resolved Hide resolved
assets/i18n/fr.json Show resolved Hide resolved
assets/i18n/fr.json Show resolved Hide resolved
Copy link
Author

@therealcorwin therealcorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change done.

@Wolfteam
Copy link
Owner

Left a few comments @therealcorwin

@therealcorwin
Copy link
Author

Hi @Wolfteam,

I just check the file, and i don't see what i forgot :/

Copy link
Owner

@Wolfteam Wolfteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wolfteam,

I just check the file, and i don't see what i forgot :/

Check the review review comments
review

assets/i18n/fr.json Show resolved Hide resolved
assets/i18n/fr.json Show resolved Hide resolved
assets/i18n/fr.json Outdated Show resolved Hide resolved
@therealcorwin
Copy link
Author

Strange I don't see your review comment :/ I fix this in few minutes

Fix : Diona description
Fix : Xiao description
@therealcorwin
Copy link
Author

I just push some modifications

@Wolfteam Wolfteam merged commit e92ce82 into Wolfteam:feature/french_translations Jul 30, 2021
@Wolfteam
Copy link
Owner

@therealcorwin I did some updates on the general and main files (the new characters, weapons, etc).
For now, I'm gonna upload a beta version with your changes, should be up in 2hrs ~.

To join the beta program, go to the play store > genshindb > join beta program > wait 5 min. > go back and you should see an update

@therealcorwin
Copy link
Author

Hi @Wolfteam,

I use the beta version (1.1.5+108 Beta).

First, when i update the app to the beta version, i can't choose French in setting's menu. I needed to delete cache/data. At first launch all the app and game data are in french. But if a want to swtich to english i can't roll back in french because i haven't this choice. Is't normal ?

About translation, No big problem. Just fix some presentation, formulation, too long text. For exemple, some weapon's name are too long, can i use "\n" to write this on two line instead of one, or not ?

@Wolfteam
Copy link
Owner

Hi @Wolfteam,

I use the beta version (1.1.5+108 Beta).

First, when i update the app to the beta version, i can't choose French in setting's menu. I needed to delete cache/data. At first launch all the app and game data are in french. But if a want to swtich to english i can't roll back in french because i haven't this choice. Is't normal ?

About translation, No big problem. Just fix some presentation, formulation, too long text. For exemple, some weapon's name are too long, can i use "\n" to write this on two line instead of one, or not ?

Hiho, gonna push a fix for the problem now, should be up in 2hrs~.

Yep you can use a line break to format the text.

@therealcorwin
Copy link
Author

Version 109 beta tested. French option is available ;)

Is there an easy solution in vscode or other to generate an APK with my translation to look at directly "in live" the modification on my computer/tablet ?

I'll do some correction this weekend and V2 data if i have enough time :)

@Wolfteam
Copy link
Owner

Version 109 beta tested. French option is available ;)

Is there an easy solution in vscode or other to generate an APK with my translation to look at directly "in live" the modification on my computer/tablet ?

I'll do some correction this weekend and V2 data if i have enough time :)

Yes, just follow the instructions that are located in the [README (https://github.com/Wolfteam/GenshinDb/blob/main/README.md) file.

After that, you should be able to run the app with one of the following commands:

Desktop:
flutter run -d windows

Android:
flutter run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/translations translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants