New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/french translations #100
Feature/french translations #100
Conversation
Fix : Mitternachts Waltz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix Ok :)
@therealcorwin Forgot to mention that I pushed a new beta with your changes yesterday |
@Wolfteam, I know :) I'm checking all my work and i will make some corrections this weekend. |
Hi @Wolfteam :) Is there a tips to center a weapon name easily or not because using "\t" is not very sexy ^_^. Or, i use a normal line break and don't center the text ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Wolfteam :)
Is there a tips to center a weapon name easily or not because using "\t" is not very sexy ^_^. Or, i use a normal line break and don't center the text ?
In the weapon list, the names are always centered.
In the weapon detail, the name is aligned to the start
So in the end, there's on need to align the names in the json file
@@ -5301,53 +5301,47 @@ | |||
"description": "Un arc peint de la couleur des nuits de péché et de fantaisie.", | |||
"refinement": "Lorsque vous touchez des ennemis avec des attaques normales, les DGT infligés par les compétences élémentaires sont augmentés de {{0}}% pendant 5s. Lorsque vous touchez des ennemis avec des compétences élémentaires, les DGT infligés par les attaques normales sont augmentés de {{1}}% pendant 5s." | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove this weapon
assets/i18n/fr.json
Outdated
"refinement": "Normal Attack hits on opponents increase Charged Attack DMG by {{0}}% for 6s. Charged Attack hits on opponents increase ATK by {{1}}% for 6s." | ||
"name": "Contes de Dodoco", | ||
"description": "Un livre de contes rempli d’histoires enfantines qui font sourire petits et grands. Même les lecteurs passés depuis longtemps à l’âge adulte ne peuvent s’empêcher d’être absorbés par les petites aventures innocentes et naïves qui y sont dépeintes.", | ||
"refinement": "Lorsque vous touchez des ennemis avec des attaques normales, les DGT infligés par les attaques chargées sont augmentés de 16% pendant 6 s. \nLorsque vous touchez des ennemis avec des attaques chargées, l’ATQ est augmentée de 8% pendant 6 s." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove the {{x}} placeholders
For example, a too long weapon name in french : It's not very nice. If i put a "\n" In the first picture, the name must adapt with the width of the frame, it will be nicer and usefull for the user, no ? |
|
May be, change dynamically the size of characters if the name is too long. With this all cards are equals., and we can read the complete name.
Yeah, it was just for the example ^^
Yes, two lines :) I lost sooooooooooooo many time with this fucking Java to emulate an android device and i haven't enough time to work on correction. I try during this week. The major part of translation is correct. Rest some cosmetic touch :) |
Translation : Ayaka Kamisato
Translation : Traveler (electro)
Translation : Traveler (electro)
Translation : Weapons patch V2.0
Translation : Materials patch V2.0