[BUG] Merge French translation

[therealcorwin]

Hi @Wolfteam,

How are you ?

During my proofreading of my translation, i noticed many inconsistency in french file between your repo and mine.

For example, Amber for her S2 :

• In French Translation branch in your repo :
  { "key": "a2", "description": "Ajuste la direction du jet.\nAjuste la portée du jet.", "descriptions": [] }

• In French Translation branch from my repo :
  { "key": "a2", "description": "Ajuste la direction et la portée du jet. La lignée de Baron Lapinou est impressionnante, mais Amber a décidé d'arrêter de compter à partir du 893e Baron Lapinou.", "descriptions": [] }

File here : https://github.com/therealcorwin/GenshinDb/blob/feature/french_translations/assets/i18n/fr.json

I don't understand where i make a mistake. When i created a PR, it's file from my repo that i used. May be a conflict during the merge ?!

[Wolfteam]

Yep I updated the character's french translations with the ones provided on discord, since those are more accurate. In the example you provided there's indeed a typo since it should be something like

        {
          "key": "a2",
          "description": null,
          "descriptions": ["Ajuste la direction du jet",  "Ajuste la portée du jet."]
        }

[therealcorwin]

One purpose of my second pass is to provided a better typo (and grammar etc ...). I check speedly the file you use and they are a lot of pbs :( Bad french, sentence with french and english words, lack of description etc...

[Wolfteam]

One purpose of my second pass is to provided a better typo (and grammar etc ...). I check speedly the file you use and they are a lot of pbs :( Bad french, sentence with french and english words, lack of description etc...

when I pushed that commit, I didn't see any typo (besides the one I indicated above).

[therealcorwin]

I don't understand very well. You don't see this sentence by example :

In French Translation branch from my repo : { "key": "a2", "description": "Ajuste la direction et la portée du jet. La lignée de Baron Lapinou est impressionnante, mais Amber a décidé d'arrêter de compter à partir du 893e Baron Lapinou.", "descriptions": [] }

in my last commit ?

[Wolfteam]

I don't understand very well. You don't see this sentence by example :

In French Translation branch from my repo : { "key": "a2", "description": "Ajuste la direction et la portée du jet. La lignée de Baron Lapinou est impressionnante, mais Amber a décidé d'arrêter de compter à partir du 893e Baron Lapinou.", "descriptions": [] }

in my last commit ?

yep i saw that one, but it is not correct, it should be like this one instead:

        {
          "key": "a2",
          "description": null,
          "descriptions": ["Ajuste la direction du jet",  "Ajuste la portée du jet."]
        }

Also the translation doesn't seem accurate, if you check at the end here you will notice what I mean

for example, let's take this line from your translation

Ajuste la direction et la portée du jet

and compare it to the one in the game / file:

Ajuste la direction du jet

There's a notable difference

[therealcorwin]

I mean it's "normal" because, when i started the translation I didn't understand the difference between "description" & "descriptionS".

My planning was very charged at this time. With the file length i decided to translate all data in french, and in a second time make some adjustment like this one (and grammar, spelling etc ...). La lignée de Baron Lapinou est impressionnante ... is a citation and i don't where place it, (and if it necessary ? ==> real question)

Now with the emulator, i understood my mistake and corrections come.

However, '"descriptions": ["Ajuste la direction du jet", "Ajuste la portée du jet."]' is correct but I wouldn’t have phrased it that way

[Wolfteam]

I mean it's "normal" because, when i started the translation I didn't understand the difference between "description" & "descriptionS".

My planning was very charged at this time. With the file length i decided to translate all data in french, and in a second time make some adjustment like this one (and grammar, spelling etc ...). La lignée de Baron Lapinou est impressionnante ... is a citation and i don't where place it, (and if it necessary ? ==> real question)

Now with the emulator, i understood my mistake and corrections come.

However, '"descriptions": ["Ajuste la direction du jet", "Ajuste la portée du jet."]' is correct but I wouldn’t have phrased it that way

yep I know, some of the translations in the game could have mistakes or maybe they are not well phrased, but since they are the official ones I still prefer to use them

[Wolfteam]

Translations are now autogenerated (except for the ui), so gonna I'm close this one