Fix #398 Move l10n to gettext (po files) #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step: Change translations from ConfigThingy to gettext internally. Need to keep the existing ConfigThingy format for template translations (which are provided by the user).
MessageFormat doesn't work with single quotes
4 tasks
for easy packing of message translations
LC_ALL is set to C anyway
SonarQube complains
No function calls in Logging calls -> have them only in English.
smehrbrodt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step: Change translations from ConfigThingy to gettext internally.
Need to keep the existing ConfigThingy format for template translations (which are provided by the user).
TODO: