Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add old values to Update and Remove operations #21

Open
olejnjak opened this issue Dec 24, 2015 · 3 comments
Open

Add old values to Update and Remove operations #21

olejnjak opened this issue Dec 24, 2015 · 3 comments
Assignees

Comments

@olejnjak
Copy link
Contributor

Hi,

I'd like to open a discussion whether it would be useful to add oldValue parameters to Update and Remove operations or I'm just missing something useful?

E.g. my current use case is this: I'm using ReactiveArray to manage annotations displayed in MKMapView. On my viewModel I have an array which changes based on items that came from API. So in cases when the array changes I'd like to update/remove appropriate annotations which currently seems to be impossible or complicated.

I think that adding a simple argument oldValue to those operations wouldn't be that complicated and would solve those cases effectively.

Other opinions? :-)

@guidomb
Copy link

guidomb commented Jan 7, 2016

I think is not too hard to add this functionality. Would you mind sending a PR?

@olejnjak
Copy link
Contributor Author

olejnjak commented Jan 7, 2016

I will when I reach my computer :)

Odesláno z iPhonu

    1. 2016 v 17:45, Guido Marucci Blas notifications@github.com:

I think is too hard to add this functionality. Would you mind sending a PR?


Reply to this email directly or view it on GitHub.

@olejnjak
Copy link
Contributor Author

Created PR #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants