feat(progress): finish offCustomGlobalEventByEventName in progress->w…

…illUnmount
Wonder-Technology · May 19, 2019 · 8a12a22 · 8a12a22
1 parent 64f3e73
commit 8a12a22
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/src/core/atom_component/intInput/IntInput.re b/src/core/atom_component/intInput/IntInput.re
@@ -1,3 +1,4 @@
+/* TODO add IntInput_test.re */
 type state = {
   inputValue: option(string),
   isDragStart: bool,
@@ -9,6 +10,8 @@ type action =
   | Blur
   | DragDrop;
 
+/* TODO refactor(duplicate) extract from IntInput and FloatInput */
+
 module Method = {
   let _change = event => {
     let inputVal =

diff --git a/src/core/atom_component/progress/Progress.re b/src/core/atom_component/progress/Progress.re
@@ -76,4 +76,11 @@ let make = (~percent: int, ~completeFunc, _children) => {
     |> StateEngineService.setState
     |> ignore;
   },
+  willUnmount: _self =>
+    ManageEventEngineService.offCustomGlobalEventByEventName(
+      ~eventName=ProgressUtils.getProgressCustomGlobalEventName(),
+      ~state=StateEngineService.unsafeGetState(),
+    )
+    |> StateEngineService.setState
+    |> ignore,
 };
diff --git a/src/service/state/engine/event/ManageEventEngineService.re b/src/service/state/engine/event/ManageEventEngineService.re
@@ -10,4 +10,6 @@ let onKeyboardEvent = ManageEventMainService.onKeyboardEvent;
 
 let onCustomGlobalEvent = ManageEventMainService.onCustomGlobalEvent;
 
+let offCustomGlobalEventByEventName = ManageEventMainService.offCustomGlobalEventByEventName;
+
 let unsubscribeDomEventStream = ManageEventMainService.unsubscribeDomEventStream;
diff --git a/test/unit/atom_component/progress/Progress_test.re b/test/unit/atom_component/progress/Progress_test.re
@@ -9,6 +9,7 @@ open Sinon;
 let _ =
   describe("Progress component", () => {
     let sandbox = getSandboxDefaultVal();
+
     let _buildProgressComponent = (percent, completeFunc) =>
       ReactTestRenderer.create(<Progress percent completeFunc />);
 
@@ -50,7 +51,7 @@ let _ =
 
           completeFunc |> expect |> not_ |> toCalled;
         });
-        test("if percent === 100, execute completeFunc", () => {
+        test("else if percent === 100, execute completeFunc", () => {
           let completeFunc = createEmptyStubWithJsObjSandbox(sandbox);
 
           _buildProgressComponent(80, completeFunc);