Unusual require statement in BondDepository

[rlkelly]

https://github.com/Wonderland-Money/contracts/blob/main/BondDepository.sol#L701

It says:

        uint profit = value.sub( payout ).sub( fee );
        ...
        treasury.deposit( _amount, address(principle), profit );
        ...
        require(balanceBefore.add(profit) == Time.balanceOf(address(this)), "Not enough Time to cover profit");

This means that it assumes that the balance has been increased by the profit. But this calls treasury.deposit( _amount, address(principle), profit ); which runs:

        uint value = valueOf(_token, _amount);
        // mint Time needed and store amount of rewards for distribution
        send_ = value.sub( _profit );
        ...
        Time.mint( msg.sender, send_ );

So I believe this only works if profit is half the value of the amount. I'm curious why this assertion is in the code.

[loic001]

very strange indeed... It would make more sense to test if there are enough tokens to cover the payout. Why cover the profit?

require(balanceBefore.add(payout) == Time.balanceOf(address(this)), "Not enough Time to cover payout"); would be better no ?