New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

player height: Using currentReferenceSpace instead of currentReferenceSpaceType #38

Closed

signorpipo opened this issue Jun 6, 2023 · 1 comment

signorpipo commented Jun 6, 2023

The component seems to be using the wrong variable to check for the reference space type, like here:

    onXRSessionStart() {
        if (!['local', 'viewer'].includes(this.engine.xr.currentReferenceSpace)) {
            this.object.resetTranslationRotation();
        }
    }

instead of currentReferenceSpace it should be currentReferenceSpaceType

sorskoot mentioned this issue

fixed issue with Reference Space in player-height #39

Merged

Collaborator

Squareys commented Jun 9, 2023

Fixed with #39

Squareys closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment