Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard covers textfield #36

Closed
KatrinLomp opened this issue Oct 12, 2017 · 5 comments
Closed

Keyboard covers textfield #36

KatrinLomp opened this issue Oct 12, 2017 · 5 comments
Labels

Comments

@KatrinLomp
Copy link

On iOS 11 there's an issue where keyboard covers the textfield where user can enter their explanation. Due to that, it is not possible to send score. Tapping on "edit score" pushes score view up like it should be when keyboard is visible, only now the keyboard is dismissed.
img_0029

@diegoserranoa
Copy link
Contributor

Hi @KatrinLomp we'll take a look at this and send a fix as soon as we can

@diegoserranoa
Copy link
Contributor

Hi @KatrinLomp we've tested in different devices and with the latest version of iOS 11.0.3 and haven't been able to reproduce this bug.

Can you give us more context of how/when this happened?

img_0010

@KatrinLomp
Copy link
Author

I was using iPhone 6 plus with iOS 11.0.2. Also tried some simulators with 11.0.1 version. I tried to debug a bit and it seems, that userInfo[UIKeyboardFrameBeginUserInfoKey] gives 0 for height on my version. That's why it's broken. This appears to be common problem:
https://stackoverflow.com/questions/45689664/ios-11-keyboard-height-is-returning-0-in-keyboard-notification

I will update my phone to 11.0.3 and see if I can still reproduce it.

@KatrinLomp
Copy link
Author

I can still reproduce it on iOS 11.0.3. I'm not sure what could be different in our code, but the cause seems clear to me. Changing UIKeyboardFrameBeginUserInfoKey with UIKeyboardFrameEndUserInfoKey will fix the issue. I have tested it on my device.

@diegoserranoa
Copy link
Contributor

Hi @KatrinLomp we've released a new version with the fix. You can check the changes here

Thank you for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants