Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing the survey when user has no email #49

Closed
backmeupplz opened this issue May 10, 2018 · 1 comment
Closed

Not showing the survey when user has no email #49

backmeupplz opened this issue May 10, 2018 · 1 comment

Comments

@backmeupplz
Copy link

It's an edge case, yet it's there. Survey isn't shown to users without email due to NSURL behaviour in WTRTrackingPixel.m:43. NSURL there simply doesn't recognize NSString URLs with <...>&email=&url=<...> where email argument is empty.

Can be fixed similarly to my fix here: backmeupplz@5d00d4e.

Thanks!

@backmeupplz
Copy link
Author

OMG, no need to fix anything. I just had an invisible character in my app token for some reason. Maybe worth checking the token for unrecognized chars? NSURL fails if it encounters weird chars there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants