Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TinyMCE icon? #113

Closed
paaljoachim opened this issue Apr 21, 2015 · 2 comments
Closed

TinyMCE icon? #113

paaljoachim opened this issue Apr 21, 2015 · 2 comments

Comments

@paaljoachim
Copy link

Hey

I notice the button is fairly huge for adding a donation form to a page/post. (It looks pretty nice next to the Add Media button though..:)

What about adding an icon to the TinyMCE bar instead? To the right of the kitchen sink icon.
@DevinWalker
Copy link
Member

TinyMCE is a pain to work with and we're happy with the button and it's placement currently. It makes it really easy to see and is much easier to code outside TinyMCE (we're working with their API with another plugin and it's tough sledding).

@paaljoachim
Copy link
Author

Gotcha! Seems you found a good route to follow..:)

jonwaldstein added a commit to jonwaldstein/givewp that referenced this issue Aug 15, 2023
@jonwaldstein
Feature: add stateless donation confirmation receipt routing, templat…
c8b6d30 
…e, and implementation (impress-org#113)

* feature: add donation receipt route, dto, view, controller, template, and rendering

* feature: make receipt settings dynamic, add query params to route url, update generators and tests

* refactor: update form logic to listen for redirects from gateways, update receipt styles to match classic form, get next gen test gateways to use new receipt route as faux redirect

* chore: scaffold same page receipt redirect for stripe

* chore: add cors to postData for offsite redirects

* feature: add concept of originId for showing receipt with multiple forms on a page

* refactor: add redirectReturnUrl to gatewayData via filter and replace individual gateway logic

* refactor: use givewp-event and givewp-listenr for redirect query params

* feature: add isEmbed, embedId and RouteListener

* feature: add backwards compatability to new receipts for legacy forms

* feature: filter sub gateway data

* chore: add receipt detail classnames

* refactor: use detail classname for icons

* refactor: use new donation status label getter

* reactor: use isReceiptIdValid

* refactor: udpate filter method names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DevinWalker @paaljoachim