Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: Terms fieldset legend #1179

Closed
ramiy opened this issue Oct 30, 2016 · 0 comments
Closed

a11y: Terms fieldset legend #1179

ramiy opened this issue Oct 30, 2016 · 0 comments
Assignees
@ramiy

Comments

@ramiy
Copy link
Contributor

ramiy commented Oct 30, 2016

Issue Overview

The donation form in the front-end has several <fieldset> groups. Each fieldset has a <legend> caption. This way we can group related form elements, and use legend for group titles.

The problem is that the Terms Fieldset has no legend. It's like it's part of the "Personal Info". We should add one.

Current Behavior

terms-legend-current

Expected Behavior

terms-legend-after

Notes

I should add that if, for any reason, you don't like it visually - we can hide the legend using CSS. But it will be visible to screen-readers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramiy ramiy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ramiy @mathetos @DevinWalker