Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dollar sign in modal doesn't always work #120

Closed
mathetos opened this issue Apr 26, 2015 · 3 comments
Closed

Dollar sign in modal doesn't always work #120

mathetos opened this issue Apr 26, 2015 · 3 comments
Assignees
@mathetos
Milestone
0.9 Release

Comments

@mathetos
Copy link
Member

Kind of hard to describe how this happens, but basically, if you click "Donate Now" the dollar sign appears in the total amount field no problem. But if you close the modal, pick a different amount and hit "Donate Now" again, you'll see "USD" instead of the dollar sign in the total amount inside the modal.

Here's a screencast showing the problem
http://screencast-o-matic.com/watch/cofOeufV9F

I also tested it by turning "Custom Amount" off, and it still did that. So it seems related to closing the modal and re-opening it.
@mathetos mathetos added the bug label Apr 26, 2015
@mathetos mathetos added this to the 0.9 Release milestone Apr 26, 2015
@DevinWalker
Copy link
Member

@mathetos how to did you get the "USD" to display? It should show the currency symbol, not the value, which is how the plugin prefixes the amount.

@DevinWalker DevinWalker assigned mathetos and unassigned DevinWalker Apr 29, 2015
@mathetos
Copy link
Member Author

I didn't attempt to have USD appear, it simply did. This is a live environment (though currently only accessible via IP address). This was a new Give installation, no Add-ons enabled. We can take a look together.

@mathetos mathetos removed the invalid label Apr 29, 2015
@mathetos
Copy link
Member Author

Looks like this is related to not having a default set for the Currency settings. Once I went and saved the Settings page, the issue went away.

pluginmirror-worker pushed a commit to wp-plugins/give that referenced this issue May 7, 2015
* New: Global options to disable the form excerpt and featured image …
e19ca6d 
…found under Give > Settings > Display Options

* New: Enable the billing details section for offline donations. The fieldset will appear above the offline donation instructions. Note: You may customize this option per form as needed. Per request impress-org/givewp#26
* New: Theme template compatibility updates for Flatsome, X Theme, and Avada, Twenty-*
* New: Two new filters introduced give_default_wrapper_start and give_default_wrapper_end to modify template wrappers
* New: PayPal Standard: Allow Option to Switch from Donations to Standard transactions impress-org/givewp#121
* New: Brazilian Portuguese Translation impress-org/givewp#107
* Update: CMB2 updated to latest
* Update: CMB2 moved directories
* Fix: Admin Multi-Level Amount Fields Not Passed through give_format_amount() impress-org/givewp#65
* Fix: Welcome screen CSS issue with WP 4.2+ impress-org/givewp#119
* Fix: Admin Form Creation: Custom Amount Text Field Won't Accept Empty Value impress-org/givewp#72
* Fix: Dollar sign in modal doesn't always work impress-org/givewp#120
* Fix: Reports > Logs > Payment Errors > View Transaction Details now opens properly in Thickbox modal - we weren't properly enqueuing thickbox styles and script in wp-admin
* For complete details of release milestone please visit: https://github.com/WordImpress/Give/issues?q=milestone%3A%220.9+Release%22

git-svn-id: https://plugins.svn.wordpress.org/give/trunk@1154927 b8457f37-d9ea-0310-8a92-e5e31aec5664
jonwaldstein added a commit to jonwaldstein/givewp that referenced this issue Aug 15, 2023
@jonwaldstein
Refactor: update default field settings, enqueue global form styles, …
3ecc9f1 
…and update form settings tab (impress-org#120)

* refactor: make displayInReceipt enabled by default

* feature: enqueue global form stylesheet to elevate css variables to the root and head tag properly

* refactor: move receipt settings into form tab

*chore: comment out unused settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathetos mathetos

Labels
None yet
Projects
None yet
Milestone
0.9 Release
Development

No branches or pull requests
2 participants
@mathetos @DevinWalker