Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple donation forms on a page with the Terms checkbox causes jumping #1244

Closed
2 tasks
DevinWalker opened this issue Nov 16, 2016 · 0 comments
Closed
2 tasks

Multiple donation forms on a page with the Terms checkbox causes jumping #1244

DevinWalker opened this issue Nov 16, 2016 · 0 comments
Assignees
@DevinWalker
Milestone
1.7

Comments

@DevinWalker
Copy link
Member

Issue Overview

When you have multiple donation forms on a page using Terms and Conditions, the checkbox jumps to the first donation form on the page when you click on another form's agreement checkbox.

2016-11-16_13-31-26

Expected Behavior

No unexpected jumping

Possible Solution

Make the ID for the field unique to the donation form.

Steps to Reproduce (for bugs)

  1. Add multiple donation forms to a page with T&Cs enabled
  2. Click on the agree checkbox on the form that is not the first
  3. You browser will jump you to the first form

Related PRs

List related PRs against other branches:

Todos

  • Tests
  • Documentation
@DevinWalker DevinWalker self-assigned this Nov 16, 2016
@DevinWalker DevinWalker added this to the 1.7 milestone Nov 16, 2016
DevinWalker pushed a commit that referenced this issue Nov 16, 2016
Gave a unique ID to the checkbox #1244
0db2c20
DevinWalker pushed a commit that referenced this issue Nov 16, 2016
Change log entry for #1244
7c89420
@DevinWalker DevinWalker mentioned this issue Nov 16, 2016
Merged
3 tasks
DevinWalker pushed a commit that referenced this issue Nov 16, 2016
Merge branch 'release/1.7' into release/1.8
2dd87d9 
* release/1.7:
  Change log entry for #1244
  Gave a unique ID to the checkbox #1244
  Do not short array tag because we support PHP 5.3 >=
  show global and default tern and agreement text conditionally
  Renamed function give_purchase_form_required_fields to give_get_required_fields #896
  Sentence closures
  Fixed incorrect array ordering #896
  Fixed incorrect ordering #896
  Check for price-functions.php in unit test
  PHP docs
  Renamed process-purchase.php to process-donation.php #896
  Sentence closures
  Deprecate give_reset_store_items in favor of give_reset_items #896
  Deprecated usage of give_get_users_purchases_args in favor of give_get_users_donations_args #896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
1 participant
@DevinWalker