Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency Separator Calculations Bug #150

Closed
DevinWalker opened this issue Jun 3, 2015 · 1 comment
Closed

Currency Separator Calculations Bug #150

DevinWalker opened this issue Jun 3, 2015 · 1 comment
Assignees
@DevinWalker
Milestone
0.9.5

Comments

@DevinWalker
Copy link
Member

The problem is the way the URL sent to paypal is composed, due to the thousand separator and the decimal separator.

In France, when you want to pay €25 it's composed this way : 25,00 € and not 25.00€
So..

If I plan 25€ with a coma "," has thousand separator, my fee will become 2,500.00€
If I plan it with a dot , paypal won't work.

bug1
bug2
bug3
@DevinWalker DevinWalker self-assigned this Jun 3, 2015
@DevinWalker DevinWalker added this to the 0.9.5 milestone Jun 3, 2015
DevinWalker pushed a commit that referenced this issue Jun 3, 2015
Fixes for currency formatting according to #150
ab3b710
DevinWalker pushed a commit that referenced this issue Jun 3, 2015
* New: Script Optimization - Give now only loads one minified JS scri…
b2e7966 
…pt and one CSS file to keep load times fast and minimize footprint

* New: Using Grunt to generate POT file now for much more timely and accurate translations
* Fix: Incorrect amount formatting when currency separators set to "," for both thousands and decimals. @see: #150
DevinWalker pushed a commit that referenced this issue Jun 4, 2015
Fixed PayPal to account for various formats for #150
e23b442
@DevinWalker
Copy link
Member Author

This is now fixed as of 0.9.5

pluginmirror-worker pushed a commit to wp-plugins/give that referenced this issue Jun 4, 2015
= 0.9.5 beta =
9245af1 
* New: [give_profile_editor] shortcode that enables donors to customize their account information on the frontend #130 impress-org/givewp#130
* New: Uninstall.php file which deletes ALL data if the user chooses to do so under Settings > Advanced
* New: composer.json file for developers
* New: Dynamic sidebar for singular Give Donation Forms. The sidebar will appear under Appearances > Widgets if you have not disabled Give's singular post type in Give > Settings > Display Options. You can add widgets of your choosing to this section and they will display to the left of your forms, below the main form featured image.
* New: Offline Donation enhancements including customizable donation instructions email sent to user upon form completion. See: impress-org/givewp#124
* New: Goals for Donation Forms. Thanks @ibndawood https://github.com/ibndawood @see impress-org/givewp#42
* New: Admin CSS improvement - Now conditional fields are indicated with a slight gray background color
* New: Script Optimization - Give now only loads one minified JS script and one CSS file to keep load times fast and minimize footprint
* New: Using Grunt to generate POT file now for much more timely and accurate translations
* New: Give now has Composer support @see: https://packagist.org/packages/wordimpress/give thanks @michaelbeil
* Fix: Admin Logs CSS: impress-org/givewp#127
* Fix: Incorrect amount formatting when currency separators set to "," for both thousands and decimals. @see: impress-org/givewp#150
* Fix: Broken "lock" image that appears above donation fields for SSL sites @see: impress-org/givewp#128
* Fix: Updated Magnific class to prevent conflicts with other Magnific modals

git-svn-id: https://plugins.svn.wordpress.org/give/trunk@1174736 b8457f37-d9ea-0310-8a92-e5e31aec5664
jonwaldstein pushed a commit to jonwaldstein/givewp that referenced this issue Aug 15, 2023
@kjohnson
chore: Update sidebar button icon (impress-org#150)
3c6cb27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
0.9.5
Development

No branches or pull requests
1 participant
@DevinWalker