Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings pages return errors w/ Hebrew #1510

Closed
ramiy opened this issue Feb 17, 2017 · 5 comments
Closed

Settings pages return errors w/ Hebrew #1510

ramiy opened this issue Feb 17, 2017 · 5 comments
Assignees
Milestone

Comments

@ramiy
Copy link
Contributor

ramiy commented Feb 17, 2017

Issue Overview

Non-English navigation returns error pages. Some tab URLs are using translation functions. They should not. It breaks the link.

Steps to Reproduce (for bugs)

  1. Change the site language (to any non-english language).
  2. Go to Give settings page.
  3. Navigate to any tab and sub-tab.
@ravinderk
Copy link
Collaborator

@ramiy I changed the language to Hindi and it is woking fine for me. Can you provide us a screenshot?

9rvfgfxjgd

@mathetos
Copy link
Member

@ravinderk I think he means languages that have active translations for those tabs. If those tabs are a different language then the hyperlink is wrong.

@ramiy
Copy link
Contributor Author

ramiy commented Feb 19, 2017

@ravinderk It seems like the Hindi language is not fully translated. Try using the Hebrew language. you will see the errors.

@DevinWalker DevinWalker modified the milestone: 1.8.3 Feb 21, 2017
@DevinWalker
Copy link
Member

I found an issue when the you'll see an error page due to the URL including the translated language:

2017-02-23_13-34-32

DevinWalker pushed a commit that referenced this issue Feb 23, 2017
@ramiy
Copy link
Contributor Author

ramiy commented Feb 23, 2017

As mentioned above, the tab value in the URL should not use translation functions.

@DevinWalker DevinWalker changed the title Settings pages return errors Settings pages return errors w/ Hebrew Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants