Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Receipt language for Offline Donation Instructions to match other instances #1840

Closed
mathetos opened this issue Jul 10, 2017 · 0 comments
Assignees
Milestone

Comments

@mathetos
Copy link
Member

Issue Overview

We refer to the Offline Donations Instructions in several different ways. It would be more efficient and easier for translators if we referred to it the same way every time.

Current Behavior

On the receipt we currently have this: esc_html_e( 'Offline Payment Instruction:', 'give' ); found here

It uses "Payment", has a colon, and is singular.

But all other instances are like this:
__( 'Offline Donation Instructions', 'give' ), using "Donation" instead of "Payment", does not have a colon, and is plural.

Possible Solution

Update the line above to be:
esc_html_e( 'Offline Donations Instructions', 'give' );

But I'm not sure how to handle the colon correctly in this case, unless it was outside the string, but then I think it would have problems with RTLs.

@ravinderk ravinderk modified the milestones: 1.8.10, 1.8.11 Jul 11, 2017
@DevinWalker DevinWalker modified the milestones: 1.8.11, 1.8.12 Jul 11, 2017
@mehul0810 mehul0810 mentioned this issue Jul 15, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants