Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Give 2.0] Enabling/Disabling the "Email access" email should be restricted by the Email Access setting #2658

Closed
mathetos opened this issue Jan 15, 2018 · 1 comment
Assignees
Milestone

Comments

@mathetos
Copy link
Member

Issue Overview

Enabling/Disabling the "Email access" email should be restricted by the Email Access setting. We already do that with the Offline Donation emails.

Expected Behavior

If "Email Access" is disabled, the "Email Access" email should not be able to be enabled since enabling it would have zero effect.

Current Behavior

The Email settings screen allows for enabling/disabling despite whatever is set in "Donations > Settings > General > Email Access".

Steps to Reproduce (for bugs)

  1. Ensure you're on the latest version of Give 2.0.
  2. Go to "Donations > Settings > General > Email Access" and make sure the "Email Access" setting is set to "Disabled".
  3. Go to "Donations > Settings > Emails" and you'll see that you have the ability to enable or disable "Email Access" email.
  4. You'll also see that the word "access" should be with a capital "A", i.e. "Email Access".
@ravinderk ravinderk added this to the 2.0 milestone Jan 15, 2018
@ravinderk
Copy link
Collaborator

ravinderk commented Jan 16, 2018

ejuguibmhb

Commits:
acaab7d...93fde83
93fde83...4190881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants