Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give donation form shortcode not respecting show_goal="false" #360

Closed
DevinWalker opened this issue Oct 23, 2015 · 3 comments
Closed

Give donation form shortcode not respecting show_goal="false" #360

DevinWalker opened this issue Oct 23, 2015 · 3 comments
Assignees
@DevinWalker
Milestone
1.3.2

Comments

@DevinWalker
Copy link
Member

Reported here: https://github.com/WordImpress/Give/issues/new

Using a shortcode such as [give_form id="114" show_title="false" show_goal="false" show_content="none" display_style="reveal" float_labels="enabled"] will result in the goal still being output incorrectly.
@DevinWalker DevinWalker added this to the 1.3.2 milestone Oct 23, 2015
@DevinWalker DevinWalker self-assigned this Oct 23, 2015
DevinWalker pushed a commit that referenced this issue Oct 23, 2015
Take into account shortcode show_goal option when outputting goal
24203dc 
Fixes #360
@DevinWalker DevinWalker mentioned this issue Oct 23, 2015
Merged
@kjbrum
Copy link

kjbrum commented Dec 10, 2015

Any idea on when the next release will be that includes this fix?

@DevinWalker
Copy link
Member Author

I'm pushing to get it out this week :)

@kjbrum
Copy link

kjbrum commented Dec 10, 2015

Awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
2 participants
@DevinWalker @kjbrum