Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress 4.4 bug and Give Tabs #377

Closed
DevinWalker opened this issue Oct 29, 2015 · 3 comments
Closed

WordPress 4.4 bug and Give Tabs #377

DevinWalker opened this issue Oct 29, 2015 · 3 comments
Assignees
@DevinWalker
Milestone
1.3.2

Comments

@DevinWalker
Copy link
Member

With the change of h1 primary titles our h2 tag shows an obvious error:

10-28-2015 5-32-35 pm
@DevinWalker DevinWalker self-assigned this Oct 29, 2015
@DevinWalker DevinWalker added this to the 1.3.2 milestone Oct 29, 2015
@DevinWalker DevinWalker changed the title WordPress 4.4 bug under Give > Settings tabs WordPress 4.4 bug and EDD Tabs Oct 29, 2015
@DevinWalker
Copy link
Member Author

It's also appearing under Reports, anywhere where tabs are used with h2s

@DevinWalker DevinWalker changed the title WordPress 4.4 bug and EDD Tabs WordPress 4.4 bug and Give Tabs Oct 29, 2015
@mathetos
Copy link
Member

I think we just have to add an H1 to the top of the page and it'll be fine right?

@DevinWalker
Copy link
Member Author

Just wrap it in an h2

DevinWalker pushed a commit that referenced this issue Oct 29, 2015
Updated nav wrappers #377
0c75de9
@DevinWalker DevinWalker mentioned this issue Oct 29, 2015
Merged
DevinWalker pushed a commit that referenced this issue Oct 29, 2015
Merge pull request #378 from WordImpress/issue/377
40bdaa9 
Updated nav wrappers #377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
2 participants
@mathetos @DevinWalker