Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/1051 #1060

Merged
merged 3 commits into from
Sep 30, 2016
Merged

Issues/1051 #1060

merged 3 commits into from
Sep 30, 2016

Conversation

ravinderk
Copy link
Collaborator

This pr will fix #1051

How Has This Been Tested?

You can use these steps to check this pr:

  1. Check if there give_site_address_before_migrate option in *_options table or not, if yes then follow step 2 or if not that reload your site and start from step 1
  2. change give_site_address_before_migrate option value to any other domain
  3. reload website and cron will run to check license status.

These steps is for quick testing because we only have to make sure that cron will run to validate license again when user migrate there site.

Screenshots (jpeg or gifs if applicable):

4u2z0nipga

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

We are handling shortly and permanently notice disable by storing user decision permanently. We do not need cookie logic js anymore.
Copy link
Member

@DevinWalker DevinWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock on!

@DevinWalker DevinWalker merged commit b21ba0c into impress-org:release/1.7 Sep 30, 2016
@ravinderk ravinderk deleted the issues/1051 branch October 20, 2016 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants