Issue/1121 #1127
Merged
Issue/1121 #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevinWalker
reviewed
Oct 17, 2016
|
@DevinWalker See commit 1d73e01. It's the only line changed. The rest is minification. |
|
Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue described in #1121 was only a problem if a new card number was pasted over existing input. If the user deleted the number and then entered a new number, there was no issue.
By clearing all credit card classes before each update, we ensure that class names do not stack on top of each other and there is only one credit card class applied at a time.
How Has This Been Tested?
SCRIPT_DEBUGset totrueandfalseTypes of changes
Fixes #1121
Checklist: