Issue/1131 #1135
Merged
Issue/1131 #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 1.7 donor emails are handled in their own functions outside of give_edit_customer(). For that reason, references to the email field are removed from the function.
DevinWalker
approved these changes
Oct 19, 2016
|
I just tested this and it's working great. Thanks for catching that bug before it ever had a chance to get out in the wild. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempting to update donor info was causing an email validation error described in #1131.
As of 1.7 donor email updates are handled in their own functions outside of
give_edit_customer(). For that reason, references to the email field are removed fromgive_edit_customer().Donor info can now be updated without error.
How Has This Been Tested?
Types of changes
Fixes #1131
Checklist: