Fix/ecommerce terminology: Rename give_checkout_button_purchase function #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form_submit_button
…on_form_submit_button
…on_form_submit_button pass 2
ravinderk
changed the title
ravinderk
changed the title
DevinWalker
requested changes
May 25, 2017
|
|
||
| _give_deprecated_function( __FUNCTION__, '1.8.8', null, $backtrace ); | ||
|
|
||
| $display_label_field = give_get_meta( $form_id, '_give_checkout_label', true ); |
There was a problem hiding this comment.
@ravinderk why don't you just call the renamed function give_get_donation_form_submit_button() within here without repeating the code?
There was a problem hiding this comment.
@DevinWalker Good catch. Thank you for handling this
DevinWalker
pushed a commit
that referenced
this pull request
May 25, 2017
…minology Code updates to PR #1730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #896
Checklist: