Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/1773 #1782

Merged
merged 4 commits into from
Jun 26, 2017
Merged

Issue/1773 #1782

merged 4 commits into from
Jun 26, 2017

Conversation

mehul0810
Copy link
Contributor

Description

This PR is for #1773

How Has This Been Tested?

Tested this deleting individual donation. Also, cancelling multiple donations and then deleting a donation to make sure there is no conflict.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

Copy link
Collaborator

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehul0810 Whenever make changes to JS file, please make sure you run gulp.

Copy link
Collaborator

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DevinWalker You can test it, Working fine for me

@ravinderk ravinderk dismissed their stale review June 19, 2017 08:37

I wan to approve this

Copy link
Collaborator

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DevinWalker You can test it, Working fine for me

@DevinWalker DevinWalker merged commit 845495e into impress-org:release/1.8.9 Jun 26, 2017
@mehul0810 mehul0810 deleted the issue/1773 branch December 8, 2017 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants