Issues/1781 #1788
Merged
Issues/1781 #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DevinWalker I added the valid tick mark to all required field for the credit card for better UI.
|
DevinWalker
requested changes
Jun 26, 2017
There was a problem hiding this comment.
@ravinderk the field errors should not show until the user has finished inputting the info. Otherwise it is distracting and annoying to the user.
|
@DevinWalker PR updated as you suggested. |
|
@DevinWalker CSS issue fixed with tick icon on floatable. |
DevinWalker
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will resolve #1781
Screenshots (jpeg or gifs if applicable):
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: