Issue/1847 #1863
Issue/1847 #1863
Conversation
Release/1.8.12
…sing pagination on donation page
Release/1.8.12
assets/js/admin/admin-scripts.js
Outdated
| var status = 'Pre-approval'; | ||
|
|
||
| // Check if admin did not select any payment. | ||
| if ( ! parseInt( $payments ) ) { |
There was a problem hiding this comment.
Please attempt to optimize this into one function. DRYer.
There was a problem hiding this comment.
@DevinWalker Optimised the script. Please check.
includes/admin/reporting/reports.php
Outdated
| $give_table->prepare_items(); | ||
| $give_table->display(); | ||
| ?> | ||
| <form class="give-forms-reports-filter" method="get"> |
There was a problem hiding this comment.
@mehul0810 Instead of directly putting form tag around the table, We can achieve this by setting api because these pages are generated by setting api
For ref:
https://github.com/WordImpress/Give/blob/master/includes/admin/reporting/class-settings-forms.php#L53
https://github.com/WordImpress/Give/blob/master/includes/admin/views/html-admin-settings.php#L21
There was a problem hiding this comment.
@ravinderk I've implemented the changes as per your suggestions.
includes/admin/tools/logs/logs.php
Outdated
| do_action( 'give_logs_donations_top' ); | ||
| ?> | ||
|
|
||
| <form class="give-logs-sales-filter" method="get" action="<?php echo 'edit.php?post_type=give_forms&page=give-tools&tab=logs'; ?>"> |
There was a problem hiding this comment.
@mehul0810 Check my comment on line number 223
…orms and donors tabs under reporting
DevinWalker
dismissed
ravinderk’s stale review
I see you've marked this as ready
| status = 'preapproval'; | ||
| } | ||
| // Get message on basis of payment count. | ||
| confirm_action_notice = ( 1 < $payments ) ? |
Description
This PR is for #1847
How Has This Been Tested?
I've tested it with various list page to make sure the pagination works properly as well as works on jumping to a specific page number. Also, checked that there is no confirmation popup on jumping to a specific page number on
Donationspage.Also, Taken care of long urls with
_wp_http_referrerincluded with listing of Logs.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: