Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/1790 #2186

Merged
merged 12 commits into from
Oct 26, 2017
Merged

Issue/1790 #2186

merged 12 commits into from
Oct 26, 2017

Conversation

mehul0810
Copy link
Contributor

Description

This PR is for #1790

How Has This Been Tested?

I have tested this using the View it in browser link with following scenario:

  • Opening it in same window where donation is performed.
  • Opening it in incognito window
  • Opening after the access token has expired to make sure it still works after verification and regenerating access token

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ravinderk ravinderk added this to the 1.8.15 milestone Oct 12, 2017
@ravinderk ravinderk self-requested a review October 13, 2017 15:09
@DevinWalker DevinWalker modified the milestones: 1.8.15, 1.8.16 Oct 19, 2017
@DevinWalker DevinWalker changed the base branch from release/1.8.15 to release/1.8.16 October 19, 2017 05:44
@DevinWalker
Copy link
Member

This is working well. Merging.

@DevinWalker DevinWalker merged commit 1a22e06 into impress-org:release/1.8.16 Oct 26, 2017
@mehul0810 mehul0810 deleted the issue/1790 branch December 8, 2017 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinderk ravinderk Awaiting requested review from ravinderk

@DevinWalker DevinWalker Awaiting requested review from DevinWalker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mehul0810 @DevinWalker @ravinderk