Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/2139 #2252

Merged
merged 5 commits into from
Oct 27, 2017
Merged

Issue/2139 #2252

merged 5 commits into from
Oct 27, 2017

Conversation

mehul0810
Copy link
Contributor

Description

This PR is for #2139

How Has This Been Tested?

Tested this with following scenarios:

Screenshots (jpeg or gifs if applicable):

Reports:
image

Settings:
image

Tools:
image

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ravinderk
Copy link
Collaborator

@mehul0810 It is working fine but can make menu loading smoother.

empzmr0rns

@mehul0810
Copy link
Contributor Author

@ravinderk I have fixed it and tested it.
gif

Copy link
Collaborator

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DevinWalker It is working fine for me. Can you review this

@DevinWalker DevinWalker changed the base branch from release/1.8.16 to release/1.8.17 October 27, 2017 20:44
@DevinWalker DevinWalker merged commit 67e1d71 into impress-org:release/1.8.17 Oct 27, 2017
@mehul0810 mehul0810 deleted the issue/2139 branch December 8, 2017 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants