Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the available currencies for the test data providers #2449

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

tw2113
Copy link
Contributor

@tw2113 tw2113 commented Dec 3, 2017

Description

The data provider for currencies had a todo note about adding more currencies. This pull request provides all the available currencies from give_get_currencies()

How Has This Been Tested?

For speed, I filtered the tests down to just test_give_get_currency_name. All tests passing at present time.

Checklist:

  • [*] My code is tested.
  • [*] My code follows the WordPress code style.
  • [*] My code follows has proper inline documentation.

@DevinWalker DevinWalker changed the base branch from master to release/1.8.17 December 4, 2017 21:21
@DevinWalker
Copy link
Member

Thanks @tw2113 !

@DevinWalker DevinWalker merged commit 7ee6a1a into impress-org:release/1.8.17 Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants