Re: #249 #251
Merged
Re: #249 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to modify the `give_require_billing_address` filtered value.
The flot plugins are enqueued in `class-give-graph.php` and not via the `admin_enqueue_scripts` hook.
|
Please see my comment over on #249 |
- Require billing address validation if $_POST contains the 'billing_country' field. - Verify that the offline form customization option is enabled when checking whether or not to show the billing fields.
|
How about something like this? |
|
The function simply checks that 'billing_country' is in $_POST and if so, returns true to require validation. I added a hook so gateways can modify the return value (they can check for their gateway name in $_POST). I'm not sure why Scrutinizer cancelled. It should be fine. |
|
Checking it out now |
DevinWalker
pushed a commit
that referenced
this pull request
Sep 16, 2015
jonwaldstein
pushed a commit
to jonwaldstein/givewp
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the comment on #249 for the reason of this pull request.
You'll probably need to test this with all of your gateway plugins to ensure that any which don't require billing address validation call the
give_require_billing_addresshook to disable it.