Remove Parameter the unwanted parameter #2663 #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raftaar1191
force-pushed
the
issues-2663
branch
from
8b4e0b6
to
bd448c5
Compare
…es-2663 Branch Update
ravinderk
requested changes
Jan 29, 2018
| * | ||
| * @return bool | ||
| */ | ||
| function give_validate_donation_amount( $valid_data, $data ) { | ||
| function give_validate_donation_amount( $valid_data ) { | ||
| $data = $_POST; |
There was a problem hiding this comment.
@raftaar1191 Do not need to create $data param please use $_POST directly with validation
There was a problem hiding this comment.
Here we are updating the $data and then adding that to DB
That why I am adding $_POST value to $data variable
-
https://github.com/WordImpress/Give/blob/release/2.0.2/includes/process-donation.php#L1188
-
https://github.com/WordImpress/Give/blob/release/2.0.2/includes/process-donation.php#L1205
I can update this function but I don't think it's needed. Let me know if you want to to updated it
…es-2663 Branch Update
ravinderk
approved these changes
Jan 29, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to fix issues #2663
How Has This Been Tested?
Manual tested
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: