Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2692 - Fix Table Creation Issue when utf8mb4 #2705

Merged
merged 7 commits into from
Jan 24, 2018

Conversation

mehul0810
Copy link
Contributor

Description

This PR resolves #2692

How Has This Been Tested?

I've tested this issue as per the below steps which ensures that custom meta tables are created:

  1. Install Give 1.8.19
  2. Create couple of donations
  3. Install Give 2.0 and run upgrade routine
  4. Donor missing scenario generated
  5. Install Give 2.0.1 - Run Upgrade Routine - Everything Fixed.

Video Link: https://drive.google.com/open?id=1MKqR7JO0R51yctZ-ttpl9_SCqkUuzkbo

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ravinderk ravinderk merged commit a794caa into impress-org:release/2.0.1 Jan 24, 2018
@mehul0810 mehul0810 deleted the issue/2692 branch January 25, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants