Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force JavaScript validation to only look at Give forms #569

Merged
merged 3 commits into from
Apr 8, 2016
Merged

Force JavaScript validation to only look at Give forms #569

merged 3 commits into from
Apr 8, 2016

Conversation

jimwebb
Copy link
Contributor

@jimwebb jimwebb commented Apr 8, 2016

Fixes conflict with MemberPress (and potentially other plugins). See Issue #568

@DevinWalker DevinWalker self-assigned this Apr 8, 2016
@DevinWalker DevinWalker added this to the 1.4.1 milestone Apr 8, 2016
@DevinWalker DevinWalker changed the title Foce JavaScript validation to only look at Give forms Force JavaScript validation to only look at Give forms Apr 8, 2016
@DevinWalker
Copy link
Member

Thanks! @jimwebb can you fix the conflict so we can merge it?

@jimwebb
Copy link
Contributor Author

jimwebb commented Apr 8, 2016

Howdy! I can't find the conflict; it merges into master fine for me, and GitHub isn't explaining what the conflict is. But I do PRs like once a year, so it might be operator error on my part.

@DevinWalker
Copy link
Member

Try merging master in this PR branch, that should fix it.

@jimwebb
Copy link
Contributor Author

jimwebb commented Apr 8, 2016

Fixed. I had an old fork. Thanks.

@DevinWalker DevinWalker merged commit 5e609b6 into impress-org:master Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants