Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP-CS-Fixer #223

Closed
Mte90 opened this issue Aug 17, 2014 · 6 comments
Closed

PHP-CS-Fixer #223

Mte90 opened this issue Aug 17, 2014 · 6 comments

Comments

@Mte90
Copy link

Mte90 commented Aug 17, 2014

After this ticket https://github.com/fabpot/PHP-CS-Fixer/issues/329 i've written this config file but i don't know if is correct.
https://github.com/Mte90/WordPress-Plugin-Boilerplate-Powered/blob/master/plugin-name/.php_cs

I think that an official config file for PHP-CS-Fixer will be very useful for everybody

@keradus
Copy link

keradus commented Aug 17, 2014

You can add Config for WP in PHP-CS-Fixer project, then nobody need to create .php_cs file to configure it.

If you want, then:

  • provide paths for pure WP
  • pack it into Config class
  • make PR with that config

and then community will decide ;)

@Mte90
Copy link
Author

Mte90 commented Aug 18, 2014

Okay but first we need to check the correct config for the wordpress ecosystem :-D

@GaryJones
Copy link
Member

@corysimmons
Copy link
Contributor

Why was this closed?

Nevermind, it's not needed since WP doesn't adhere to any of the PHP standards.

@GaryJones
Copy link
Member

PHPCS now supports automatic fixing via the phpcbf feature. None (or very few) of the custom WP sniffs have been adapted to support automatic fixing yet, but it is something to consider when someone has sufficient time to contribute.

@corysimmons
Copy link
Contributor

Yeah I just noticed the phpcbf feature. Nice!

It seems to act weird sometimes but I'll open up new issues for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants