Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme Handbook Overhaul] Global Settings and Styles > Styles #1117

Closed
Tracked by #816 ...
justintadlock opened this issue Sep 18, 2023 · 7 comments
Closed
Tracked by #816 ...

[Theme Handbook Overhaul] Global Settings and Styles > Styles #1117

justintadlock opened this issue Sep 18, 2023 · 7 comments
Assignees
Labels
developer documentation (DevHub) Improvements or additions to developer documentation new document Requests for new page/article. [Status] Done Issue is completed themes Issues for Theme Developer Handbook

Comments

@justintadlock
Copy link

This ticket is a part of #816 and will be used for creating new page titled "Styles" under Chapter 3: Global Settings and Styles

I will draft the content for the new page in a Google Doc: https://docs.google.com/document/d/11SuTqMXWx_vm9BMDDg_L_ZDnmZyv60tDiZKwitIAWF0/edit?usp=sharing

@justintadlock justintadlock added developer documentation (DevHub) Improvements or additions to developer documentation new document Requests for new page/article. themes Issues for Theme Developer Handbook labels Sep 18, 2023
@justintadlock justintadlock self-assigned this Sep 18, 2023
@github-actions
Copy link

Heads up @kafleg @carolinan @TeBenachi - the "themes" label was applied to this issue.

@github-actions
Copy link

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@justintadlock
Copy link
Author

After mapping the outline for this doc, I came to the conclusion that this is best split into four separate documents (this includes the intro and three sub-docs):

  • Styles (introduces theme.json's styles structure)
    • Applying Styles (how to apply styles to root, elements, blocks)
    • Using Presets (how to reference presets from settings presets)
    • Supported Styles (reference to every available style)

This was one of the questions I'd pondered when we made the outline. I wasn't sure what it'd look like until we really got into it. But after outlining all of this, I realized that this would be a massively long doc if it wasn't split up.

@justintadlock
Copy link
Author

This intro doc is now drafted and can be reviewed: https://docs.google.com/document/d/11SuTqMXWx_vm9BMDDg_L_ZDnmZyv60tDiZKwitIAWF0/edit?usp=sharing

@justintadlock
Copy link
Author

This has now been ported to the Theme Handbook as a draft: https://developer.wordpress.org/wp-admin/post.php?post=148909&action=edit

@kafleg
Copy link
Member

kafleg commented Sep 29, 2023

Looks good.

@justintadlock
Copy link
Author

@github-actions github-actions bot added the [Status] Done Issue is completed label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer documentation (DevHub) Improvements or additions to developer documentation new document Requests for new page/article. [Status] Done Issue is completed themes Issues for Theme Developer Handbook
Projects
None yet
Development

No branches or pull requests

2 participants