Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme Handbook Overhaul] Patterns > Using PHP in Patterns #1480

Closed
Tracked by #816
justintadlock opened this issue Mar 5, 2024 · 7 comments
Closed
Tracked by #816

[Theme Handbook Overhaul] Patterns > Using PHP in Patterns #1480

justintadlock opened this issue Mar 5, 2024 · 7 comments
Assignees
Labels
developer documentation (DevHub) Improvements or additions to developer documentation new document Requests for new page/article. [Status] Done Issue is completed themes Issues for Theme Developer Handbook

Comments

@justintadlock
Copy link

This ticket is a part of #816 and will be used for creating new page titled "Using PHP in Patterns" under the "Patterns" chapter.

The content for the new page will be drafted in a Google Doc: https://docs.google.com/document/d/1b4K4w1GyW09Z-yJpwAODT3mPqQCDAG3H7Xr3kgqyWyg/edit?usp=sharing

@justintadlock justintadlock added developer documentation (DevHub) Improvements or additions to developer documentation new document Requests for new page/article. themes Issues for Theme Developer Handbook labels Mar 5, 2024
@justintadlock justintadlock self-assigned this Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Heads up @kafleg @carolinan @TeBenachi - the "themes" label was applied to this issue.

Copy link

github-actions bot commented Mar 5, 2024

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@justintadlock
Copy link
Author

The first draft of this doc is now ready for review.

@carolinan
Copy link
Collaborator

carolinan commented Mar 11, 2024

This is great, educational and detailed. It needs some minor cleanup of the text domains in the larger code examples.

I am not sure that unregistering patterns should be included in this document.

@justintadlock
Copy link
Author

This s great, educational and detailed. It needs some minor cleanup of the text domains in the larger code examples.

Thanks. Cleaned up the missing textdomain.

I am not sure that unregistering patterns should be included in this document.

Removed that section from the notes. Just a copy/paste fail into the wrong doc. :)

@kafleg
Copy link
Member

kafleg commented Apr 12, 2024

Looks good to me.

@justintadlock
Copy link
Author

@github-actions github-actions bot added the [Status] Done Issue is completed label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer documentation (DevHub) Improvements or additions to developer documentation new document Requests for new page/article. [Status] Done Issue is completed themes Issues for Theme Developer Handbook
Projects
None yet
Development

No branches or pull requests

3 participants