Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HelpHub] Separator block #462

Closed
8 tasks
femkreations opened this issue Sep 24, 2022 · 11 comments
Closed
8 tasks

[HelpHub] Separator block #462

femkreations opened this issue Sep 24, 2022 · 11 comments
Assignees
Labels
6.0 Changes in 6.0 release 6.1 Changes in 6.1 release block editor Gutenberg related issues medium priority [Status] Done Issue is completed user documentation (HelpHub) Improvements or additions to end-user documentation

Comments

@femkreations
Copy link
Collaborator

femkreations commented Sep 24, 2022

Article: https://wordpress.org/support/article/separator-block/

Updating for 6.1

  • Add top & bottom margin support. 40551

Updating for 6.0

  • Block Styles: Show style preview when hovered or focused. 34522

General

  • Make sure all screenshots are relevant to the latest version
  • Make sure videos are up to date
  • Add ALT tags for the images
  • Make sure the headings are in sentence case
  • Convert all reusable blocks to a ‘regular block’.
  • Update the changelog at the end of the article
@colorful-tones colorful-tones self-assigned this Sep 27, 2022
@colorful-tones
Copy link
Member

Grabbing this for Friday.

@colorful-tones
Copy link
Member

I only had time to review the current doc for this today and all the static screenshots are fine and no changes need to be made.

I did not check alt tags, but will. Also, I will complete the rest of the checklist. The video at the top should be replaced. I'll circle back and get these updates in place and publish for a future time.

@femkreations femkreations added the 6.0 Changes in 6.0 release label Oct 5, 2022
@colorful-tones
Copy link
Member

I'm unassigning this as I'm not able to get to it.

@colorful-tones colorful-tones removed their assignment Nov 22, 2022
@maitreyie-chavan
Copy link

@femkreations Please assign this to me

@maitreyie-chavan
Copy link

@femkreations Here's a suggestion to update the existing article's Style section to include the update made in 6.0 #34522


Styles

You can modify the Separator block's look by choosing one of the styles available in the block's settings on right-hand side under Styles.

Screenshot 2023-02-17 at 10 58 24 AM

Default, Wide Line and Dots are the 3 options to choose from, and you can either hover or focus click on each of the style option to get a preview of their appearance

Default style

The line separator will appear centrally aligned with a short length

Screenshot 2023-02-17 at 10 52 29 AM

Wide Line style

This style will spread the line separator across the content width having a longer length

Screenshot 2023-02-17 at 10 53 03 AM

Dots style

The short solid line seen in the Default style is replaced with a centred dotted line

Screenshot 2023-02-17 at 10 53 23 AM

Note
The above style options may vary based on the active theme

@maitreyie-chavan
Copy link

@femkreations Here's a suggestion to update the existing article and add a Dimensions section to include the update made in 6.1 #40551


Dimensions

The separator block provides the ability to add padding and margin values via the Dimensions settings option, giving you more control over creating the content separation

Screenshot 2023-02-17 at 11 27 16 AM

For more details, refer to this support article: Dimension settings overview

@zzap zzap assigned atachibana and unassigned maitreyie-chavan May 9, 2023
@atachibana
Copy link
Collaborator

Tahir Shahzad will review this issue. I'll assign this issue to him after I got his GitHub account.

@zzap zzap mentioned this issue May 9, 2023
13 tasks
@tahir-shahzad4
Copy link

tahir-shahzad4 commented May 16, 2023

@femkreations
I have Reviewed the article and modifications suggested by @maitreyie-chavan

  • Suggestions for style update are fine
  • Suggestions for dimensions update are fine

Further item that needs to be done

  • Video needs to be updated
  • Current article have alt attribute with images. For new changes, maybe we can write alt description below image to review.
  • Headings are not in sentence case
  • Change log needs to be udpated

@femkreations
Copy link
Collaborator Author

Moving this to the 6.2 project board

@jomarieminney
Copy link

I can re-record the video and make the updates in WP for this one if you want to assign it to me

@jomarieminney
Copy link

@femkreations this can be closed now :)

@zzap zzap closed this as completed Jul 2, 2023
@github-actions github-actions bot added the [Status] Done Issue is completed label Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.0 Changes in 6.0 release 6.1 Changes in 6.1 release block editor Gutenberg related issues medium priority [Status] Done Issue is completed user documentation (HelpHub) Improvements or additions to end-user documentation
Projects
Status: Done
Development

No branches or pull requests

7 participants