Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The og:image tag image references the old content types #1329

Open
jonathanbossenger opened this issue Feb 10, 2023 · 9 comments
Open

The og:image tag image references the old content types #1329

jonathanbossenger opened this issue Feb 10, 2023 · 9 comments
Labels
[Type] Bug Something isn't working on the Learn website.

Comments

@jonathanbossenger
Copy link
Collaborator

jonathanbossenger commented Feb 10, 2023

Description

When sharing the learn.wordpress.org site on social media (like Facebook) the social sharing image, which is fetched from the og:image meta tag, still references the old content types

https://s.w.org/images/learn-thumbnail-fallback.jpg

'Workshops' are now 'Tutorials'
'Discussion Groups' are now 'Online Workshops'

It would be great if we could get that image updated.

@jonathanbossenger jonathanbossenger added [Type] Bug Something isn't working on the Learn website. Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Feb 10, 2023
@jonathanbossenger
Copy link
Collaborator Author

Props to @DaisyOlsen who first reported this.

@jonathanbossenger
Copy link
Collaborator Author

@adamwoodnz would you be able to look into this in the coming week?

@adamwoodnz
Copy link
Contributor

@adamwoodnz would you be able to look into this in the coming week?

Yep!

@adamwoodnz adamwoodnz self-assigned this Feb 12, 2023
@adamwoodnz
Copy link
Contributor

Requested a new asset be created https://wordpress.slack.com/archives/C02S78ZAL/p1676317990048819

@bsanevans bsanevans removed the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Feb 17, 2023
@jasmussen
Copy link

Hey @adamwoodnz sorry for the belated response here.

I wonder if we should create this asset as part of the overall Learn refresh, rather than before? Otherwise, CC: @WordPress/meta-design for awareness.

@adamwoodnz
Copy link
Contributor

adamwoodnz commented Mar 16, 2023

@adamwoodnz
Copy link
Contributor

Commits
https://dotorg.trac.wordpress.org/changeset/20120
https://meta.trac.wordpress.org/changeset/12473

@courtneyr-dev
Copy link
Collaborator

Let's get courses on there yet too folks.

@courtneyr-dev courtneyr-dev reopened this Mar 16, 2023
@adamwoodnz
Copy link
Contributor

Let's get courses on there yet too folks.

We don't have an icon for courses as far as I can see, and it seems like adding that might change the format of the image. I think it needs more design attention. Could it wait til the redesign as @jasmussen suggested?

@adamwoodnz adamwoodnz removed their assignment Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working on the Learn website.
Projects
Status: To do
Development

No branches or pull requests

5 participants