Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop Post Type #3

Closed
StevenDufresne opened this issue Aug 4, 2020 · 9 comments
Closed

Workshop Post Type #3

StevenDufresne opened this issue Aug 4, 2020 · 9 comments
Assignees
Labels
[Component] Learn Plugin Website development issues related to the Learn plugin.
Milestone

Comments

@StevenDufresne
Copy link
Contributor

StevenDufresne commented Aug 4, 2020

https://www.figma.com/file/UtmG8KQv3Csy8hNtuAWkwZ/Learn-WordPress?node-id=15%3A1390

Features:

  • Video
  • Video Meta data
  • Content
  • Author Informaton
  • Join Discussion -> Forum support

Excerpt from tardis regarding content:

Each workshop post will need to have:
Title
Description
Video (this could be either from WPTV or YouTube)
A set of comprehension questions
A set of learning outcomes
Presenter's .org username (this will then need to fetch their name and avatar for display)

We should probably write these as blocks within a post template?

Questions:

  • Where do the videos live?
  • Do we have a plugin for the video player?
  • Should we write the video player component as a Gutenberg block?
@StevenDufresne StevenDufresne changed the title Workshop Page: Layout Workshop Page Aug 4, 2020
@coreymckrill
Copy link
Contributor

coreymckrill commented Aug 4, 2020

Some more questions:

  • What if the workshop is broken up into multiple videos / lessons (ala this comment)?
  • Related to the above, should videos get a prescribed place in a workshop post, or should they just be normal video embed blocks arranged within other post content as needed?
  • Should a presenter be set as the author of the workshop post?
  • What if there are multiple presenters?
  • How could we support multiple workshops/lessons that are part of a series?

It kind of seems like these could all just be lumped into the normal block editor content field:

Description
Video (this could be either from WPTV or YouTube)
A set of comprehension questions
A set of learning outcomes

Perhaps new workshop posts just start with a default block pattern as a template that can then be modified?

@coreymckrill
Copy link
Contributor

Where do the videos live?
Do we have a plugin for the video player?
Should we write the video player component as a Gutenberg block?

The videos definitely won't live on wporg infrastructure, so they'll be hosted by a video streaming service (wp.tv or YouTube). Perhaps the list of allowed platforms would only be limited by which ones Core supports for embedding, but that would be more of a policy question. As long as we're relying on Core embed support, we won't need any special plugins, and blocks should already exist for them.

@coreymckrill coreymckrill changed the title Workshop Page Workshop Post Type Aug 4, 2020
@coreymckrill
Copy link
Contributor

For the workshop landing page and archives, it looks like we need to be able to pull out the (first?) video from a particular workshop post in the case that it's featured, and also a still from the video for when it's displayed in a grid of workshops.

So each post probably also needs:

  • A featured image
  • A meta field for inputting the video URL or embed code

@StevenDufresne
Copy link
Contributor Author

Noting: When you get a chance, please turn on feature images for the CPT.

@StevenDufresne
Copy link
Contributor Author

Noting: When you get a chance, please turn on feature images for the CPT.

I've done this. Nevermind.

@hlashbrooke
Copy link
Collaborator

What if the workshop is broken up into multiple videos / lessons (ala this comment)?
How could we support multiple workshops/lessons that are part of a series?

A manual solution could be to simply add a link to the content when loading the workshop, but a more elegant solution would be an additional series taxonomy that we could use in these instances.

Related to the above, should videos get a prescribed place in a workshop post, or should they just be normal video embed blocks arranged within other post content as needed?

The way I see it, we could either have it (and the other data) as custom fields, or we could create post templates in gutenberg and then use those - that would eliminate the need for custom fields, but it would also provide the same structure for each workshop post, but still allowing for some flexibility if needed.

Should a presenter be set as the author of the workshop post?
What if there are multiple presenters?

I would say the presenter should be a custom field, like it is for WordCamp sessions. That way we can add a comma-separated list of .org usernames and it would show however many we need on the frontend. If the presenter is the author then it would be tough to account for multiple presenters.

@coreymckrill coreymckrill self-assigned this Aug 5, 2020
@coreymckrill coreymckrill added the [Component] Learn Plugin Website development issues related to the Learn plugin. label Aug 6, 2020
@coreymckrill coreymckrill added this to the Soft Launch milestone Aug 6, 2020
@CdrMarks
Copy link
Collaborator

CdrMarks commented Aug 8, 2020

On a fresh install running trunk (38c404c), I get a white screen when browsing to http://localhost:8888/wp-admin/post-new.php?post_type=wporg_workshop

The browser did receive source; it's attached. add-workshop.html.txt

Here is Chrome's Developer Tools Console as well.
image

This is happening on the post editor screens for new and edits to exiting pages, posts, lesson-plans and workshop.

Disabling the Jetpack plugin allows the post editor screens to load.

@coreymckrill
Copy link
Contributor

@CdrMarks I just opened a new issue for this: #27

@coreymckrill
Copy link
Contributor

The only thing left on this, as far as I can tell, is having a way to show the video from a workshop in other places besides the single workshop view. #73 is one idea to address this, which we may or may not implement. Either way, I'm going to close this in favor of that PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Plugin Website development issues related to the Learn plugin.
Projects
None yet
Development

No branches or pull requests

4 participants