Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure during import when processing invalid links #12

Open
ldesgrange opened this issue Aug 12, 2023 · 0 comments
Open

Failure during import when processing invalid links #12

ldesgrange opened this issue Aug 12, 2023 · 0 comments

Comments

@ldesgrange
Copy link

ldesgrange commented Aug 12, 2023

As the comment says:

@unlink($tmp); // clean up, copied this from other examples but how is this supposed to work if $tmp is an error??

…this line can’t work.

I actually had an error reported here (invalid link), and because of @unlink($tmp);, the import process crashes. I think it will be better to just ignore the link and continue with the next image (replace that line with return $tmp;?).
There are other similar lines in that function, they probably deserve to be fixed the same way as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant