New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome version gone #7

Closed
Krinkle opened this Issue Jul 26, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@Krinkle

Krinkle commented Jul 26, 2013

screen shot 2013-07-26 at 10 50 03 pm

Probably something in those regular expressions stopped working with Wikipedia's current markup.

@Krinkle

This comment has been minimized.

Krinkle commented Jul 26, 2013

A few days ago, this Wikipedia edit, changed Wikipedia's internal Template:Latest_stable_software_release/Google_Chrome macro to use the display parameter latest_release_version to be invoked twice instead of once.

It seems the intention of the editor was to display the platform versions separately. This also resulted in the display parameter no longer containing a value that was purely numerical, instead it now contained a platform label in front of it.

  {{LSR
  |article = Google Chrome
- |latest_release_version = 28.0.1500.72 
+ |latest_release_version = '''Microsoft Windows'''<br /> 28.0.1500.72 
  |latest_release_date = {{start date and age|2013|07|12}}
  }}
+ {{LSR
+ |article = Google Chrome
+ |latest_release_version = '''Linux''' and '''Mac OS X'''<br />28.0.1500.71 
+ |latest_release_date = {{start date and age|2013|07|09}}
  }}

This broke the logic at functions.php#L101-L115 because the first "word" (separated by whitespace) after = on the line in question, no longer contains any numbers.

I've temporarily "fixed" it by changing the format on Wikipedia back to how it was (revision #565936923; discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment