Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block - Menu setting not preserved on "Save Changes" #574

Closed
jqmg opened this issue Apr 19, 2024 · 2 comments
Closed

Navigation block - Menu setting not preserved on "Save Changes" #574

jqmg opened this issue Apr 19, 2024 · 2 comments

Comments

@jqmg
Copy link

jqmg commented Apr 19, 2024

Versions

WordPress 6.5.2
Twenty Twenty-Four 1.1
Create Block Theme 2.0.2

Problem

I have a site header using two different menus.
When I use the create block theme option "Save changes" both navigation blocks reference same menu.

Before "save changes" the menus in the code look like this:

<!-- wp:navigation {"ref":10} /-->
<!-- wp:navigation {"ref":4} /-->

After "save changes" the menus in the code look like this:

<!-- wp:navigation {"ref":10} /-->
<!-- wp:navigation {"ref":10} /-->

How to replicate issue

  1. Activate twentytwentyfour theme, install Create Block Theme.
  2. Edit site / edit header / add two navigation blocks and create distinct menus for each.
  3. Click Save, preview the site, everything looks fine here.
  4. Now click the Create Block Theme wrench icon and click "Save Changes", both your navigation blocks are now using the same menu.
@madhusudhand
Copy link
Contributor

Will be fixed in: #572

@pbking
Copy link
Contributor

pbking commented Apr 23, 2024

This should be fixed in #572 by leaving the "Remove Navigation Refs" option UNCHECKED when saving your site.

NOTE: That nav refs should still be removed when your theme is ready to distribute to another environment.

Closing this, but if you find it is still an issue please reopen and we will dig in further.

@pbking pbking closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants