Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audits: Ability to specify groups of properties for property-values audit #7

Closed
laras126 opened this issue Oct 8, 2020 · 2 comments

Comments

@laras126
Copy link
Collaborator

laras126 commented Oct 8, 2020

For generating the HTML report, we need a way to specify groups of property-values for the reports. This was accomplished with the CLI table by re-running the command with different values, but for the HTML report, we want to get the audit data for multiple groups at one time. One idea for accomplishing this is to specify an external JSON config file that contains the groups of properties to be audited, and that can be passed to the property-values option to process.

A related need is for a higher level grouping of the output of the --property-values audit. For example, we would want the output of these audits to be under a "Typography" heading in the HTML report:

--property-values=font-size
--property-values=line-height
--property-values=font-weight

And similarly, these we might want to have under "Spacing":

--property-values=padding,padding-top,padding-bottom,padding-left,padding-right
--property-values=margin,margin-top,margin-bottom,margin-left,margin-right

This could also be accomplished with the external config approach, but maybe there are other ideas!

@ryelle
Copy link
Collaborator

ryelle commented Apr 1, 2021

@laras126 Do you think this is "done" now that we can group audits like the typography audit?

@laras126
Copy link
Collaborator Author

laras126 commented Apr 1, 2021

Yes!

@laras126 laras126 closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants