Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beyond Block Styles: Part 3 #153

Closed
justintadlock opened this issue Jul 27, 2023 Discussed in #130 · 11 comments
Closed

Beyond Block Styles: Part 3 #153

justintadlock opened this issue Jul 27, 2023 Discussed in #130 · 11 comments
Assignees

Comments

@justintadlock
Copy link

This will be Part 3 of a planned three-part series. It will teach theme authors how to create a custom icon picker control for the Separator block.

For the full details, see:

@justintadlock
Copy link
Author

@justintadlock
Copy link
Author

@justintadlock
Copy link
Author

Thanks to @ndiego for a first review.

@marybaum
Copy link
Member

marybaum commented Aug 2, 2023 via email

@bph
Copy link
Collaborator

bph commented Aug 2, 2023

I went through the example and it works. I also left a few comments on the Google Doc.

Philosophically, I just noticed that would like to follow along with first adding the start button then do the progressive enhancements on the pieces. I didn't like that I had to wait until the very end to get to see something on my test site.

Your approach was that of a very experience developer who has plenty of architectural foresight on how to approach things and does so methodically.

Even with my many years of development, I always put the places where things would go first and then fill them up with the pieces. This might not make any sense to someone, who isn't me, though. 🤣

@justintadlock
Copy link
Author

Thanks, @bph. Yes, I'd considered a few different approaches to it. What you described about getting one piece in place and then building on top of it progressively was one of those approaches.

I decided against that because it would've meant adding placeholder code in a couple of spots and re-doing it in later steps. This would've made the post much longer and created more potential areas for a reader to make a mistake.

I definitely see the benefit of doing it that way (you get a quick "win" or two and build confidence as a reader), and will keep it in mind for future posts.

@bph
Copy link
Collaborator

bph commented Aug 3, 2023

Just a short note: I am still debugging the issue: I don't get the icon into the editor nor on the frontend. The gradients seem to come over.

Gradient-only.mp4

@justintadlock
Copy link
Author

@bph - It looks like you're missing the icon-specific CSS from Part 2 (second block of code here): https://developer.wordpress.org/news/2023/07/beyond-block-styles-part-2-building-a-custom-style-for-the-separator-block/#designing-icon-separators

@marybaum
Copy link
Member

marybaum commented Aug 3, 2023

Done and out of the tab!

@justintadlock
Copy link
Author

Thank you, @marybaum.

@justintadlock
Copy link
Author

And we're live! 🎉 https://developer.wordpress.org/news/2023/08/beyond-block-styles-part-3-building-custom-design-tools/

Thanks for all the help getting this across the finish line, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Published (Done)
Development

No branches or pull requests

3 participants